Bagshui 🎒 Feng shui for your bags

[Surtugal]

Great addon, thanks!

I have a question regarding Outfit() (?):

Let’s say I have ItemRack and I create a custom category with rule Outfit(„Heal“) for my healing equipment. Most of the stuff saved under „Heal“ gets placed in there but not all of it. Sometimes gear just appears in the general gear section. Could that be because of enchants?

What happens when two categories share the same items? Where do the items get placed? Let’s say you have a tank and a dd set.

[Jx]

Great addon, thanks!

Glad you're enjoying it!

Let’s say I have ItemRack and I create a custom category with rule Outfit(„Heal“) for my healing equipment. Most of the stuff saved under „Heal“ gets placed in there but not all of it. Sometimes gear just appears in the general gear section. Could that be because of enchants?

Please update to 1.4.9 and see if it's better. I had changed Outfitter integration to ignore enchant codes a while back, but never did it for ItemRack until now, so thanks for letting me know!

What happens when two categories share the same items? Where do the items get placed? Let’s say you have a tank and a dd set.

That's controlled by the Category's Sequence number.

[Surtugal]

Wow, thanks a lot!

[Ashwhole]

Incredibly good addon u created m8, well done!

Bit confusing to configure imo, but still the best inventory addon for twow!

[Jx]

Incredibly good addon u created m8, well done!

Bit confusing to configure imo, but still the best inventory addon for twow!

Thanks! It can be difficult to balance powerful customization and ease of use, so I'd be interested to hear any suggestions for making things more intuitive.

[Kwivvir]

I'm trying to figure out whether this is an Addon issue or something else causing it..
While I love your addon, and will continue using it regardless of this issue, here it is...

I am logging in using the TWoW Launcher, and the Addons tab in the Launcher will show this addon needing Updated , every time I log on.
This is the only addon that does this, so I kind of suspect the addon.
Any ideas?

[Jx]

I am logging in using the TWoW Launcher, and the Addons tab in the Launcher will show this addon needing Updated , every time I log on.
This is the only addon that does this, so I kind of suspect the addon.
Any ideas?

I've pushed an update per day over the last four days, so that feels like it tracks. I just tested with the TW launcher and after pulling the latest version, it recognized that it was up to date.

That said, a lot of people (including me) still prefer to update addons via GitAddonsManager and just use the launcher for game updates, at least for the time being.

[RandoOnSteam]

I've read the docs a few times but I haven't figured out how to get to the (old?) all-in-one style with slot sorting. I was hoping maybe there would be a way to toggle between category sorting and all-in-one?

Also is there a way to "refresh" its sync with outfitter. Sometimes items that were removed from sets stay in "My Gear".

[Jx]

I've read the docs a few times but I haven't figured out how to get to the (old?) all-in-one style with slot sorting.

Check the very last line of the relevant FAQ: How do I switch to the OneBag-style layout?.
"If you prefer automatic sorting, just change the default Sort Order in the Structure Settings to Standard."

I was hoping maybe there would be a way to toggle between category sorting and all-in-one?

There's nothing like that right now, but I have thought that some sort of "Welcome"/"Switch Personality" dialog might eventually be a nice addition.

Also is there a way to "refresh" its sync with outfitter. Sometimes items that were removed from sets stay in "My Gear".

There's no Outfitter integration in the default Structure; it's up to you to create a custom Category that uses the Outfit() rule function. "My Gear" has two assigned Categories, Soulbound Gear and Equipped Gear, so what I think you're probably seeing is items that you have previously equipped (which you can remove from the equipped item history using the Alt+RIght-click item menu).

If you want to have a Group that includes only items you have in an Outfitter outfit:

1. Create a new Category ("My Outfits" maybe?) with a Rule of:

   Code: Select all

   Outfit()

2. Save the Category.
3. Go into Edit Mode and click the [+] where you want your new Group, then give it a name (can also be "My Outfits" if that makes sense to you).
4. Right-click the Group you just created and assign the My Outfits Category (or whatever you called it).

The same general idea applies even if you switch to the non-categorized layout, only instead of creating a new Group, you would just assign the new Category to the single Inventory Group and then all items that belong to any Outfitter outfit will be sorted together.


Hopefully all this is helpful and makes sense!

[Kwivvir]

I am logging in using the TWoW Launcher, and the Addons tab in the Launcher will show this addon needing Updated , every time I log on.
This is the only addon that does this, so I kind of suspect the addon.
Any ideas?

I've pushed an update per day over the last four days, so that feels like it tracks. I just tested with the TW launcher and after pulling the latest version, it recognized that it was up to date.

That said, a lot of people (including me) still prefer to update addons via GitAddonsManager and just use the launcher for game updates, at least for the time being.

Got it figured out... I checked it on GitAddonsManager, and it didn't show update available.. but it did ask if I wanted to DOWNGRADE. I downgraded and all good now.
Not sure how it happened, but hey... whatever works right?
Thx

[Jx]

Bagshui’s Biggest Update Yet

What’s new in 1.5

• Automated bag swapping
• Shiny new toolbar buttons
• Selling protection for valuable items
• More sensible gear slot sorting
• Improved utilization display
• Powerful new rule functions
• And more…

Check out the full changelog here.

Share some love
If you enjoy using Bagshui and want to support development, donations are hugely appreciated.

[Biktop]

Is it possible to somehow auto-organize the bags? Whenever I swap to my riding gear, or back to normal gear, I can't see the change unless I manually organize the bags with the button in the top bar. Pretty annoying!

[Jx]

Is it possible to somehow auto-organize the bags? Whenever I swap to my riding gear, or back to normal gear, I can't see the change unless I manually organize the bags with the button in the top bar. Pretty annoying!

Sorry to hear things aren't quite working the way you'd like!

I realize this isn't exactly what you're looking for, but you can assign a hotkey to Bagshui's Organize All command (in the normal WoW Key Bindings dialog). It's not automatic, but it might be a little faster than clicking the toolbar icon.


Aside from that, there's not currently an option to auto-organize when things change -- and that's by design. Early in development, Bagshui reorganized the window whenever anything changed, but I found that this made operations like splitting a stack of items feel somewhat disorienting. You would split the stack, place the split items in an empty slot, and they would instantly be whisked away somewhere else, so you'd have to hunt them down if you were going to sell/trade/list them.

I’ve captured your feedback and will consider whether there might be a way to classify item movements so that, for example, bulk equipment changes could be responded to differently from splitting a stack.

Thanks for using Bagshui!

[Downwithopp]

Love to get a destroy item button, Starting with items with lowest vendor value item in your bag moving up. maybe exclude uncommon items and higher.

[Jx]

Love to get a destroy item button, Starting with items with lowest vendor value item in your bag moving up. maybe exclude uncommon items and higher.

Thanks for the suggestion! As much as I want to be able to say yes to everything, this is unlikely to be implemented very soon. Along with some (surmountable) technical reasons, there’s the philosophical implication of starting to add destructive actions - something that has not been part of Bagshui’s design so far. That’s not to say it won’t ever happen, just that it’s slightly uncomfortable territory I would prefer to see handled by other addons.

Hopefully there’s another solution out there (or someone willing to build one) that will fill the gap for you!

[Foreverdelta33]

@Jx: Hey bro, Im currently in the making of a UI replacement, and since bagshui is so good, Im not even going to bother creating a bag addon, instead Im going to leave it at blizzard default and rather just create an implementation, mainly just a skin for bagshui.

Since Im not on your level of coding, I thought it might be good to ask you what the best
way would be according to you; I can detect your addon and basically just remove your textures
and place my own onto it, but I wanted to know if there is a more professional way to do it,
or if I should keep it as simple as that.

Tell me what u think, and again great addon you made there.

Take care.

[Jx]

I thought it might be good to ask you what the best
way would be according to you; I can detect your addon and basically just remove your textures
and place my own onto it, but I wanted to know if there is a more professional way to do it,
or if I should keep it as simple as that.

Good to hear Bagshui is working well for you! In regards to skinning, there currently isn’t a clean way to hook in and offer additional appearance options (it’s one of the areas where I took an expedient approach so I could actually reach 1.0 before the heat death of the universe).

So off the top of my head, I think it’s either the approach you’re considering, or messing with Config\Skins.lua and reapplying any changes after each update.

Good luck, and I’m curious to see what you come up with!

[Foreverdelta33]

Good luck, and I’m curious to see what you come up with!

Alright chief. Thanks alot dude.

[Erkangorgulu2]

great addon

[Foreverdelta33]

Hey JX i dont want tobe annoying, but I have to ask you a quick last question here,
it is slightly BagShui related so its not spam :)

I just wanted to ask you a small technical question, about your usage of "assert".
BagShui uses "assert" a total of 122 times, and you didnt wrap it into any kind of debug flag,
just the normal "assert". Pfui on the other hand uses "assert" only a total of 3 times.

You and Shagu are both pro, so whats the reasoning behind it?
Shagu told me, that he studied the 1.12.1 client for like 12 years and that he is self-taught,
but obviously he is a great dev,

so 2 questions basically; Why does pfui almost never use assert and Bagshui uses it plenty of times,
and why do you release Bagshui with assert in the code, without any debug flag or anything?

Ive been told that assert shouldnt be left activated so it doesnt stop the tool for the user
when something goes wrong.

But im super unsure. If you could answer this it would be a big help for me. Thanks again
Im learning so much from you and shagu. Take care.

[Jx]

Why does pfui almost never use assert and Bagshui uses it plenty of times, and why do you release Bagshui with assert in the code, without any debug flag or anything?

I can’t really speak to pfUI (and I’m not entirely sure how pro I am ), but as far as my usage goes, it’s mostly at places where the downstream code would error anyway if the assert wasn’t there. When used this way in the context of a WoW addon, an assertion can provide a more useful error message than just allowing the code it’s protecting to fail. At least that’s my thought process.

[Foreverdelta33]

Why does pfui almost never use assert and Bagshui uses it plenty of times, and why do you release Bagshui with assert in the code, without any debug flag or anything?

I can’t really speak to pfUI (and I’m not entirely sure how pro I am ), but as far as my usage goes, it’s mostly at places where the downstream code would error anyway if the assert wasn’t there. When used this way in the context of a WoW addon, an assertion can provide a more useful error message than just allowing the code it’s protecting to fail. At least that’s my thought process.

Oh thats so cool.

Ive read so many different perspectives on the internet, another one was, more from a dev perspective,
to look at asserts as "improved comments" that do more for you then just being a comment,
was also very interessting, but your view on this is also a great addition and makes me a bit more confident
in using it. I was just so confused why one great programmer uses it, and the other one doesnt.
I had my assert wrapped in a debug toggle condition before, but then i also got convinced, that
its better to have my user get a good error message at a critical point and have me fix it rather then
silently ignoring it and have it in my code (right?), so basically what youre saying.

Thanks alot of taking your time for this, and from my view youre surely pro.
Took my quite a while to even understand what bagshui is doing and to understand the core-setup.

Btw im playing vanilla for like 15 years on and off, and all the time I wished a bag addon would
allow me to swap a bag without having to empty it first. The fact you added that now were im barely
playing anymore is just so sad. Lol.

[Evilko]

Can you add ability to link items in chat from Offline Bank?

[Pizzayo]

I can’t really speak to pfUI (and I’m not entirely sure how pro I am ), but as far as my usage goes, it’s mostly at places where the downstream code would error anyway if the assert wasn’t there. When used this way in the context of a WoW addon, an assertion can provide a more useful error message than just allowing the code it’s protecting to fail. At least that’s my thought process.

Oh man I'll have to start using assert, thanks! Outing myself as a noob here but didn't even know that was available

[Jx]

Can you add ability to link items in chat from Offline Bank?

That would definitely make sense! Captured here, and I hope to add it in a future version.

[antinuke365]

hello! After the Recent Launcher update.

Bagshui now spams:
(Bagshui Bags) Updating Inventory cache

Is there any fix for this? i tried reinstalling but it doesnt work thank you

[Jx]

hello! After the Recent Launcher update.

Bagshui now spams:
(Bagshui Bags) Updating Inventory cache

Is there any fix for this? i tried reinstalling but it doesnt work thank you

The launcher must be unexpectedly enabling the !BagshuiDebug addon. Please uncheck it in the AddOns selection screen before you enter the game.

[antinuke365]

awesome thank you very much fixed now!

[Jx]

awesome thank you very much fixed now!

No problem, and thanks for the heads up! I’ve just pushed a change to prevent any further installations of the debug addon.

[Explosiv]

Great Work, love youre Addon! I can be dump sometimes (Guzruul can confirm it), but where can i change the Itemslot per row to 8? Because its triggerd me that i can see the 2 empty slots in the first row.. :D

[Jx]

where can i change the Itemslot per row to 8?

Answered on Discord, but for the record here as well:

Right now you’d need to change line 865 of Config\Settings.lua to

Code: Select all

min = 8,

And also reduce line 101 of Config\Skins.lua from 400 to something lower

Code: Select all

inventoryWindowMinWidth = 400,

Then reload your UI.

I’ll tweak it officially in a future update.

[drinkwater99]

The addon is very cool but please tell me how to fix one problem, my pfui uses invisible fonts and with your addon I see the damage numbers on the screen again, is there any way to fix this?

[Jx]

The addon is very cool but please tell me how to fix one problem, my pfui uses invisible fonts and with your addon I see the damage numbers on the screen again, is there any way to fix this?

That’s extremely unexpected… I can’t think of any way Bagshui would be affecting pfUI’s settings or the damage font.

Does the issue occur with only pfUI and Bagshui enabled (i.e. all other addons disabled)?

And does it go back to invisible when you disable Bagshui?

[drinkwater99]

The addon is very cool but please tell me how to fix one problem, my pfui uses invisible fonts and with your addon I see the damage numbers on the screen again, is there any way to fix this?

That’s extremely unexpected… I can’t think of any way Bagshui would be affecting pfUI’s settings or the damage font.

Does the issue occur with only pfUI and Bagshui enabled (i.e. all other addons disabled)?

And does it go back to invisible when you disable Bagshui?

if I turn off Bagshui everything goes back to normal, and when I turn it on I see the damage text on my screen again even though I have an invisible font in pfui, I thought it might be because of MikScrollingBattleText but it works as it should and turning it off has no effect

[Jx]

if I turn off Bagshui everything goes back to normal, and when I turn it on I see the damage text on my screen again even though I have an invisible font in pfui

I’ll see if I can reproduce this when I get some time. Sorry for the difficulty!