[Release] Bagshui 🎒 All-In-One Inventory Addon

Tools to improve your life or just make it shinier.
User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Sat Jan 04, 2025 9:06 pm

Tyrchast wrote: Tue Dec 31, 2024 10:48 am Just curious, would it be possible to add a filter to equippable items that haven’t been added to your transmog wardrobe yet?
This is now available! To get it set up:
  1. Update to the latest Bagshui (1.1 or higher required).
  2. Follow the directions on the Bagshui-Tmog page.
Important: If you had previously installed my Tmog fork, please replace it with the main version of Tmog.

User avatar
Secrett
Posts: 1

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Secrett » Sun Jan 05, 2025 2:30 pm

I cant figure out how to add specific items to custom categories and its a bit frustrating, to be more specific I'm trying to make my engineering crafts be in a seperate "Engineering" category but i cant figure it out for the life of me

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Sun Jan 05, 2025 3:16 pm

Secrett wrote: Sun Jan 05, 2025 2:30 pm I'm trying to make my engineering crafts be in a seperate "Engineering" category
As noted on the wiki and the in-game rule function menu [𝗙𝒙], the following should work. At least in theory, assuming there isn’t a major bug I missed.

Code: Select all

ProfessionCraft("Engineering")
Keep in mind the limitations of this method.

Alternatively, you could try using the PeriodicTable() function. Check the Item Information window to get a list of an item’s PT sets. Installing AtlasLoot and leveraging its data via PeriodicTable() may give you more accurate/up-to-date results than the built-in PT library.

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Sun Jan 05, 2025 10:02 pm

JackTupp wrote: Wed Jan 01, 2025 11:58 pm It is possible to always show the item inventory quantity info like in the alt click?
Serbz wrote: Thu Jan 02, 2025 4:05 pm I would really like an option with one big bag that has the ability to sort by item type but not sort automatically everytime I open my bag.
Both of these are now available in 1.2. See changelog for details.

Kord2998
Posts: 14
Has liked: 4 times
Likes: 5 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Kord2998 » Mon Jan 06, 2025 6:24 am

Secrett wrote: Sun Jan 05, 2025 2:30 pm I cant figure out how to add specific items to custom categories and its a bit frustrating, to be more specific I'm trying to make my engineering crafts be in a seperate "Engineering" category but i cant figure it out for the life of me
I'm also having a bit of trouble with this. I'm just trying to change the categories of some items to other existing categories and conceptually it feels like I should be able to alt click an item in my bag (to select it individually) and move it to another category. It does say "Select a new location" when I do this, but then when I click a new location it just gives me a menu for "Direct Assignment" that only has "New..." as an option. If I select that I get an edit category page, but I don't know what to do here. It wants me to type in a new category name, but I just want to direct assign it to an existing category.

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Mon Jan 06, 2025 11:06 am

Kord2998 wrote: Mon Jan 06, 2025 6:24 am
Secrett wrote: Sun Jan 05, 2025 2:30 pm I cant figure out how to add specific items to custom categories and it’s a bit frustrating…
… I just want to direct assign it to an existing category.
I think the confusion may be coming from the fact that the built-in Categories are read-only, which is why the only option you’re seeing is to create a new custom one.

Custom Categories will have a lower sequence number by default and will be evaluated first, catching the items and preventing them from being matched by the built-in Categories. (You can even give your custom Categories the same names as the built-ins.)

Bagshui was designed this way so that built-in Categories and Sort Orders can be revised in updates without affecting any custom objects.

Also keep in mind that the Groups you seen in the inventory Structure (layout) have Categories assigned to them, not items. The wiki has a diagram that visualizes Bagshui’s hierarchy.

Hopefully this helps explain things!

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Mon Jan 06, 2025 7:35 pm

Jx wrote: Mon Jan 06, 2025 11:06 am
Kord2998 wrote: Mon Jan 06, 2025 6:24 am
Secrett wrote: Sun Jan 05, 2025 2:30 pm I cant figure out how to add specific items to custom categories and it’s a bit frustrating…
… I just want to direct assign it to an existing category.
(My attempt to address what turned out to to be some serious bugginess.)
Someone opened an issue for problems they were having with Direct Assignment, so I did some testing and… oops! Here's what you've probably been running into and how to work around it for now. Sorry about this -- I'll try to get it corrected soon!

JackTupp
Posts: 5
Has liked: 8 times
Likes: 2 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by JackTupp » Mon Jan 06, 2025 9:42 pm

I found a little conflict with the tooltip and 2 other addons. No errors. Just a blank tooltip box.
Equipment Compare and Aux.
Here is how to reproduce with those.
Open auction house. Aux opens. search for an armor or weapon in Aux. Then mouse over the item in Aux search results. Works.
Click the "Blizzard UI" button in Aux. Regular AH windows opens. Mouse over the item in the Blizz UI. With always tooltip without alt on, a blank tooltip appears.
With always tooltip off thing, mouse over that item in Blizz UI. Tooltip for Equip Compare works. Then press alt. Blank tooltip. Release alt. Normal. Press again.
No other problems. Amazing work! Luv it! THX!

EDIT: It seem like it only happens near the top of the screen with the above. Probably not a conflict. A slight bug? IDK. See below.
I opened my bag. I move the frame near the top to test. I moused over an item. Any item in the top couple of rows of the frame. Pressed alt. (Always show without alt option was unchecked) Got and error:
AddOns\Bagshui\Components\Bagshui.Tooltips.lua:314 attempt to perform arithmetic on a nil value
Easy to reproduce.

Only seems to happen on the top rows of the frame with the frame near the top of the game.
I use a 4K monitor in fullscreen window.
Hope this helps.
Last edited by JackTupp on Tue Jan 07, 2025 12:07 am, edited 3 times in total.

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Tue Jan 07, 2025 12:35 am

Jx wrote: Mon Jan 06, 2025 7:35 pm
Jx wrote: Mon Jan 06, 2025 11:06 am
Kord2998 wrote: Mon Jan 06, 2025 6:24 am … I just want to direct assign it to an existing category.
(My attempt to address what turned out to to be some serious bugginess.)
Bug identified.
Bagshui 1.2.1 fixes the bug and Direct Assignment should hopefully work somewhat intuitively now. Sorry for the confusion!

Kord2998
Posts: 14
Has liked: 4 times
Likes: 5 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Kord2998 » Wed Jan 08, 2025 9:18 am

Is there any way to reset the position of your bank window? My game lagged out for a minute while dragging my bank window and now I can't see the window anywhere. I'm guessing it's either located off screen somehow or bugged out some other way, but I can't get it to show (even through a relog).

I used to use Engbags before your (much better) addon and it would occasionally happen to me there too, but it had a /eb resetdefaults command I could use to reset the location and get it back. Is there anything like that with bagshui?

thanks <3

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Wed Jan 08, 2025 2:21 pm

Kord2998 wrote: Wed Jan 08, 2025 9:18 am Is there any way to reset the position of your bank window? … I can't get it to show (even through a relog).
Apologies for the oversight! I want to fix this properly if I can, but heres a temporary workaround.

Kord2998
Posts: 14
Has liked: 4 times
Likes: 5 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Kord2998 » Wed Jan 08, 2025 9:06 pm

Jx wrote: Wed Jan 08, 2025 2:21 pm
Kord2998 wrote: Wed Jan 08, 2025 9:18 am Is there any way to reset the position of your bank window? … I can't get it to show (even through a relog).
Apologies for the oversight! I want to fix this properly if I can, but heres a temporary workaround.
Have my window back now. Thanks!

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Thu Jan 09, 2025 12:30 am

Jx wrote: Wed Jan 08, 2025 2:21 pm
Kord2998 wrote: Wed Jan 08, 2025 9:18 am Is there any way to reset the position of your bank window? … I can't get it to show (even through a relog).
Apologies for the oversight! I want to fix this properly if I can, but heres a temporary workaround.
In 1.2.2 it should no longer be possible for windows to get lost forever. Check the changelog for details.

JackTupp
Posts: 5
Has liked: 8 times
Likes: 2 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by JackTupp » Thu Jan 09, 2025 10:30 pm

Not sure you saw my post above. I edited it a few times.
viewtopic.php?p=115670#p115670

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Fri Jan 10, 2025 11:13 am

JackTupp wrote: Thu Jan 09, 2025 10:30 pm Not sure you saw my post above. I edited it a few times.
viewtopic.php?p=115670#p115670
You’re right, I totally missed that! Thanks for the detailed report - I’ve opened an issue to track it.

JackTupp
Posts: 5
Has liked: 8 times
Likes: 2 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by JackTupp » Wed Jan 15, 2025 3:12 pm

I am getting this with latest fix: Window position reset because it was off screen.
4K 3840x2160 in window mode.

This occurs when I move the bag window near the right side of the screen. It is not off screen at all.
But after closing it, I appears on the left side of the screen. And it is slightly off scree. And I see the off screen message in chat.

I can move the window way off screen on the left side and it will open in the same spot.

Seems like window position detection is not accurate or something. Might be resolution related?

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Wed Jan 15, 2025 10:16 pm

🚨 Please update for an important bug fix

Bagshui 1.2.6 fixes a bug where the wrong quest would be abandonded under certain circumstances. Thanks to Icekronik for the report!

Full changelog available here, as always.

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Wed Jan 15, 2025 11:14 pm

JackTupp wrote: Wed Jan 15, 2025 3:12 pm Seems like window position detection is not accurate or something. Might be resolution related?
Darn, I thought I had that implemented accurately. Let me see what I can come up with…

User avatar
Jx
Posts: 43
Has liked: 16 times
Likes: 25 times

Re: [Release] Bagshui 🎒 All-In-One Inventory Addon

Post by Jx » Thu Jan 16, 2025 2:58 am

Jx wrote: Wed Jan 15, 2025 11:14 pm
JackTupp wrote: Wed Jan 15, 2025 3:12 pm Seems like window position detection is not accurate or something. Might be resolution related?
Darn, I thought I had that implemented accurately. Let me see what I can come up with…
Improved in 1.2.8. Thanks as always!

Post Reply